Finish the smithy-json deserializer codegen #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
approved these changes
Jun 22, 2021
| } | ||
| } | ||
| override fun additionalHeaders(operationShape: OperationShape): List<Pair<String, String>> = | ||
| listOf("X-Amz-Target" to "${protocolConfig.serviceShape.id.name}.${operationShape.id.name}") |
There was a problem hiding this comment.
this should be x-amz-target so that hyper doesn't need to re-case it for us
| "Ok(body) => #1T { kind: #1TKind::$variantName(body), meta: generic },", | ||
| errorSymbol | ||
| override fun parseGenericError(operationShape: OperationShape): RuntimeType { | ||
| return RuntimeType.forInlineFun("parse_generic_error", "json_deser") { |
There was a problem hiding this comment.
nit: you can have this be a single Rust block which is typically a little easier to read
rcoh
approved these changes
Jun 23, 2021
| operation: OperationShape, | ||
| outputBodyFactory: StructureModifier | ||
| ): List<StructureShape> { | ||
| private fun syntheticOutputShapes(operation: OperationShape): List<StructureShape> { |
There was a problem hiding this comment.
can this just be StructureShape? now?
There was a problem hiding this comment.
I think in this particular case, the code is actually cleaner with them being lists since the code that calls these functions is pretty clean that way, even if they only ever have one element. I would have to convert them at the call sites otherwise.
| operation: OperationShape, | ||
| inputBodyFactory: StructureModifier | ||
| ): List<StructureShape> { | ||
| private fun syntheticInputShapes(operation: OperationShape): List<StructureShape> { |
There was a problem hiding this comment.
same here re: StructureShape?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161. This is the last of the JSON refactor.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.